-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macOS support #149
base: main
Are you sure you want to change the base?
Add macOS support #149
Conversation
visionOS support also coming? :) |
@@ -9,6 +9,7 @@ type MarkdownStyle = MarkdownTextInputDecoractorView.MarkdownStyle; | |||
|
|||
const FONT_FAMILY_MONOSPACE = Platform.select({ | |||
ios: 'Courier', | |||
macos: 'Courier', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
macos: 'Courier', | |
macos: 'SF Mono', |
Can we use SF Mono
as default for macOS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, thanks for this suggestion! Do we want to stick with Courier
on iOS though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done a bit of checking, and looks like SF fonts are not included by default for all systems to this day on both iOS and macOS.
In this case Menlo
or Monaco
could be a viable alternative for both platforms:
Any updates on this one? MacOS support would be huge! |
Details
Related Issues
GH_LINK
Manual Tests
Linked PRs